Adding a test to capture an expected edge case in Reblocking #8928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldgauthier
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the scientific tests in WARP when updating GATK from 4.5.0.0 -> 4.6.0.0 caught a difference in ReblockGVCFs when a no call site with GQ=0 was derived from a low quality call where the PLs with a value of 0 were in an allele that was subset (e.g.
<NON_REF>). I believe this new behavior is a feature because it now correctly outputs a ref block with GQ=0.This test provides an example of one of these cases to ensure that the behavior stays the same in the future.